Skip to content

chore: switch to pdm#157

Open
mjspeck wants to merge 8 commits intoOthersideAI:mainfrom
mjspeck:switch-to-pdm
Open

chore: switch to pdm#157
mjspeck wants to merge 8 commits intoOthersideAI:mainfrom
mjspeck:switch-to-pdm

Conversation

@mjspeck
Copy link
Contributor

@mjspeck mjspeck commented Feb 7, 2024 •
edited
Loading

What does this PR do?

Fixes #155

Requirement/Documentation

  • If there is a requirement document, please, share it here.

Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)

  • Chore (refactoring code, technical debt, workflow improvements)
    - [ ] New feature (non-breaking change which adds functionality)
    - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
    - [ ] Tests (Unit/Integration/E2E or any other test)
    - [ ] This change requires a documentation update

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected. Make sure before submitting this PR you run tests with evaluate.py

Note

- Do not merge before merging #154 Rebased those changes so they're not in this branch

@mjspeck mjspeck changed the title Switch to pdm chore: switch to pdm Feb 7, 2024
@mjspeck
Copy link
Contributor Author

mjspeck commented Feb 7, 2024

Just realized I should either update or remove run.sh and update the README for this. Will do that when I have a bit more time.

@mjspeck mjspeck mentioned this pull request Feb 9, 2024
Merged
1 task
@mjspeck
Copy link
Contributor Author

mjspeck commented Feb 9, 2024

FYI:

WARNING: Unable to find a resolution because the following dependencies don't work on all Python versions in the range of the project's 
`requires-python`: >=3.8.
  python>=3.9 (from <Candidate google-generativeai@0.3.2 from https://pypi.org/simple/google-generativeai/>)
A possible solution is to change the value of `requires-python` in pyproject.toml to >=3.9.

@mjspeck
Copy link
Contributor Author

mjspeck commented Feb 9, 2024

@joshbickett after you commented about using setup.py to publish, I realized that it happens in your GitHub actions. I updated those with what I think is the appropriate workflow to publish with pdm. It should also test the package across multiple python versions (relevant because there's actually a dependency that doesn't work in 3.8 even though in the old GitHub actions you were using Python 3.8) and different OSes (which should prevent future problems like #162).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE] Improve requirements

1 participant

@mjspeck